Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[location-verification / geofencing]: decrease radius minimum to "1" for circle-area #285

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

maxl2287
Copy link
Contributor

@maxl2287 maxl2287 commented Jan 8, 2025

What type of PR is this?

Add one of the following kinds:

  • enhancement/feature

What this PR does / why we need it:

This PR decreses the minimum of a circle-area radius to "1".
The provider of the API can restrict then the minimum and respond with HTTP-422 if the size of the area is to small and cannot be covered.

Which issue(s) this PR fixes:

Fixes #282

Special notes for reviewers:

Changelog input

 release-note
* [location-verification / geofencing]: decrease radius minimum to "1" for circle-area

@maxl2287 maxl2287 added enhancement New feature or request Spring25 labels Jan 8, 2025
@maxl2287 maxl2287 self-assigned this Jan 8, 2025
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but hope we'll have some collision with #281 for location-verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Spring25
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Verification/Geofencing]: Decrease the minimum of a Circle radius
2 participants